Duplicate Records Created From Stored Procedure

Please start any new threads on our new site at https://forums.sqlteam.com. We've got lots of great SQL Server experts to answer whatever question you can come up with.

All Forums

General SQL Server Forums

New to SQL Server Programming

Duplicate Records Created From Stored Procedure

Author

Topic

stdwi
Starting Member

3 Posts

Posted - 2009-03-02 : 09:48:09

The following procedure creates duplicate entries in the Quote table and I cannot figure out why or how to stop it. Any help would be greatly appreciated.

USE [Estimator]
GO
/****** Object: StoredProcedure [dbo].[QuoteApproval] Script Date: 03/02/2009 09:38:16 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
-- =============================================
-- Author: Michael Ventrella
-- Create date: March 1,2009
-- Description: QuoteApproval
-- =============================================
ALTER PROCEDURE [dbo].[QuoteApproval]
-- Add the parameters for the stored procedure here
@estno int = 0

AS
BEGIN
-- SET NOCOUNT ON added to prevent extra result sets from
-- interfering with SELECT statements.
SET NOCOUNT OFF;

-- Insert statements for procedure here

INSERT INTO Quote
(estimateno, date, customer, contact, partno, partname, englev, blankl, blankw, terms, currency, exchange, delivery, fob, jobno, address, city,
postalcode, rfqno, comments, partpic, homelinecost, transport, carrycost, operno, quantity, diename, diel, diew, diesh, construction, processprice,
simulationprice, designprice, price2c, price2d, price3c, price3d, assyprice, spotprice, tryprice, discount, price, quoteno)
SELECT QuoteCalcHeader.estimateno, QuoteCalcHeader.date, QuoteCalcHeader.customer, QuoteCalcHeader.contact, QuoteCalcHeader.partno,
QuoteCalcHeader.partname, QuoteCalcHeader.englev, QuoteCalcHeader.blankl, QuoteCalcHeader.blankw, QuoteCalcHeader.terms,
QuoteCalcHeader.currency, QuoteCalcHeader.exchange, QuoteCalcHeader.delivery, QuoteCalcHeader.fob, QuoteCalcHeader.jobno,
QuoteCalcHeader.address, QuoteCalcHeader.city, QuoteCalcHeader.postalcode, QuoteCalcHeader.rfqno, QuoteCalcHeader.comments,
QuoteCalcHeader.partpic, QuoteCalcHeader.homelinecost, QuoteCalcHeader.transport, QuoteCalcHeader.carrycost, QuoteCalcBody.operno,
QuoteCalcBody.quantity, QuoteCalcBody.diename, QuoteCalcBody.diel, QuoteCalcBody.diew, QuoteCalcBody.diesh, QuoteCalcBody.construction,
QuoteCalcBody.processprice, QuoteCalcBody.simulationprice, QuoteCalcBody.designprice, QuoteCalcBody.price2c, QuoteCalcBody.price2d,
QuoteCalcBody.price3c, QuoteCalcBody.price3d, QuoteCalcBody.assyprice, QuoteCalcBody.spotprice, QuoteCalcBody.tryprice,
QuoteCalcBody.discount, QuoteCalcBody.price, LastQuoteNumber.quoteno
FROM QuoteCalcHeader INNER JOIN
QuoteCalcBody ON QuoteCalcHeader.estimateno = QuoteCalcBody.estno CROSS JOIN
LastQuoteNumber
WHERE estimateno = @estno
-- SELECT @estno
END

visakh16
Very Important crosS Applying yaK Herder

52326 Posts

Posted - 2009-03-02 : 09:50:46

run the below query for a value of estno. i think its returning duplicates. in which case, you need to take distinct or apply group by depending on your business rules


SELECT QuoteCalcHeader.estimateno, QuoteCalcHeader.date, QuoteCalcHeader.customer, QuoteCalcHeader.contact, QuoteCalcHeader.partno, 
QuoteCalcHeader.partname, QuoteCalcHeader.englev, QuoteCalcHeader.blankl, QuoteCalcHeader.blankw, QuoteCalcHeader.terms, 
QuoteCalcHeader.currency, QuoteCalcHeader.exchange, QuoteCalcHeader.delivery, QuoteCalcHeader.fob, QuoteCalcHeader.jobno, 
QuoteCalcHeader.address, QuoteCalcHeader.city, QuoteCalcHeader.postalcode, QuoteCalcHeader.rfqno, QuoteCalcHeader.comments, 
QuoteCalcHeader.partpic, QuoteCalcHeader.homelinecost, QuoteCalcHeader.transport, QuoteCalcHeader.carrycost, QuoteCalcBody.operno, 
QuoteCalcBody.quantity, QuoteCalcBody.diename, QuoteCalcBody.diel, QuoteCalcBody.diew, QuoteCalcBody.diesh, QuoteCalcBody.construction, 
QuoteCalcBody.processprice, QuoteCalcBody.simulationprice, QuoteCalcBody.designprice, QuoteCalcBody.price2c, QuoteCalcBody.price2d, 
QuoteCalcBody.price3c, QuoteCalcBody.price3d, QuoteCalcBody.assyprice, QuoteCalcBody.spotprice, QuoteCalcBody.tryprice, 
QuoteCalcBody.discount, QuoteCalcBody.price, LastQuoteNumber.quoteno
FROM QuoteCalcHeader INNER JOIN
QuoteCalcBody ON QuoteCalcHeader.estimateno = QuoteCalcBody.estno CROSS JOIN
LastQuoteNumber
WHERE estimateno = @estno

stdwi
Starting Member

3 Posts

Posted - 2009-03-02 : 09:54:51

I ran the following code and no duplicates where created.

SELECT QuoteCalcHeader.estimateno, QuoteCalcHeader.date, QuoteCalcHeader.customer, QuoteCalcHeader.contact, QuoteCalcHeader.partno,
QuoteCalcHeader.partname, QuoteCalcHeader.englev, QuoteCalcHeader.blankl, QuoteCalcHeader.blankw, QuoteCalcHeader.terms,
QuoteCalcHeader.currency, QuoteCalcHeader.exchange, QuoteCalcHeader.delivery, QuoteCalcHeader.fob, QuoteCalcHeader.jobno,
QuoteCalcHeader.address, QuoteCalcHeader.city, QuoteCalcHeader.postalcode, QuoteCalcHeader.rfqno, QuoteCalcHeader.comments,
QuoteCalcHeader.partpic, QuoteCalcHeader.homelinecost, QuoteCalcHeader.transport, QuoteCalcHeader.carrycost, QuoteCalcBody.operno,
QuoteCalcBody.quantity, QuoteCalcBody.diename, QuoteCalcBody.diel, QuoteCalcBody.diew, QuoteCalcBody.diesh, QuoteCalcBody.construction,
QuoteCalcBody.processprice, QuoteCalcBody.simulationprice, QuoteCalcBody.designprice, QuoteCalcBody.price2c, QuoteCalcBody.price2d,
QuoteCalcBody.price3c, QuoteCalcBody.price3d, QuoteCalcBody.assyprice, QuoteCalcBody.spotprice, QuoteCalcBody.tryprice,
QuoteCalcBody.discount, QuoteCalcBody.price, LastQuoteNumber.quoteno
FROM QuoteCalcHeader INNER JOIN
QuoteCalcBody ON QuoteCalcHeader.estimateno = QuoteCalcBody.estno CROSS JOIN
LastQuoteNumber
WHERE estimateno = 7523

Subscribe to SQLTeam.com

SQLTeam.com Articles via RSS

SQLTeam.com Weblog via RSS

- Advertisement -

Resources