help with sql syntax - SQL Server Forums

Please start any new threads on our new site at https://forums.sqlteam.com. We've got lots of great SQL Server experts to answer whatever question you can come up with.

All Forums

SQL Server 2005 Forums

Transact-SQL (2005)

help with sql syntax

Author

Topic

mike123
Master Smack Fu Yak Hacker

1462 Posts

Posted - 2009-09-02 : 02:59:36

Hey Guys,

I am trying to create the SP below, but can't figure out my error.

It is erroring out on the line pasted below.

Any help is much appreciated.

Thanks once again!
Mike123

Error:

Msg 102, Level 15, State 1, Procedure insert_orderedItem_Version, Line 13
Incorrect syntax near '='.
Msg 102, Level 15, State 1, Procedure insert_orderedItem_Version, Line 18
Incorrect syntax near 'versionID'.

CREATE PROCEDURE [dbo].[insert_orderedItem_Version]
(
@itemCode varchar(6),
@commentsInstructions varchar(5000)
)
AS SET NOCOUNT ON

DECLARE @itemID int
DECLARE @versionID int
SELECT @itemID = itemID FROM tblordereditems WHERE itemCode = @itemCode
SELECT max(versionID) + 1 = @versionID FROM [tblOrderedItem_Versions] WHERE itemID = @itemID

INSERT INTO [bannerninjas].[dbo].[tblOrderedItem_Versions]
(
[itemID]
[versionID]
,[commentsInstructions]
,[revisionDate]
,[revisionStatusID]
)
VALUES
(
@itemID,
@versionID,
@commentsInstructions,
getDate(),
0
)

GO

madhivanan
Premature Yak Congratulator

22864 Posts

Posted - 2009-09-02 : 03:29:16

SELECT max(versionID) + 1 = @versionID FROM [tblOrderedItem_Versions] WHERE itemID = @itemID

should be

SELECT @versionID = max(versionID) + 1 FROM [tblOrderedItem_Versions] WHERE itemID = @itemID

Madhivanan

Failing to plan is Planning to fail

Sachin.Nand

2937 Posts

Posted - 2009-09-02 : 03:29:39

First error
SELECT max(versionID) + 1 = @versionID FROM [tblOrderedItem_Versions] WHERE itemID = @itemID
I guess it shud be
SELECT @versionID=max(versionID) + 1 FROM [tblOrderedItem_Versions] WHERE itemID = @itemID

Second error
U are missing a comma after [itemID] in the insert statement

[itemID]
[versionID]
,[commentsInstructions]

PBUH

mike123
Master Smack Fu Yak Hacker

1462 Posts

Posted - 2009-09-02 : 04:01:31

much appreciated !:)

thanks again,
mike123

Subscribe to SQLTeam.com

SQLTeam.com Articles via RSS

SQLTeam.com Weblog via RSS

- Advertisement -

Resources