ALTER PROCEDURE sp_login (
    @LoginNumber VARCHAR(255),
    @UserName VARCHAR(255),
    @Password VARCHAR(255),
    @Active BIT OUTPUT )
AS
SELECT @Active = Active
FROM Users
WHERE (LoginNumber = @LoginNumber)  AND (UserName = @UserName) AND (Password = @Password)
  
  

quote:

---

Originally posted by yanivz

i have this stored procedure

ALTER PROCEDURE sp_login (
    @LoginNumber VARCHAR(255),
    @UserName VARCHAR(255),
    @Password VARCHAR(255),
    @Active BIT OUTPUT )
AS
SELECT @Active = Active
FROM Users
WHERE (LoginNumber = @LoginNumber)  AND (UserName = @UserName) AND (Password = @Password)
  
  

i have records in users table and the stored procedure does not returns records when i execute.
can someone tell me what is wrong here, please ?

---

ALTER PROCEDURE sp_login (
    @LoginNumber VARCHAR(255),
    @UserName VARCHAR(255),
    @Password VARCHAR(255),
    @Active BIT OUTPUT )
AS
SELECT @Active = Active
FROM Users
WHERE (LoginNumber = @LoginNumber)  AND (UserName = @UserName) AND (Password = @Password)

SELECT @Active
  
  

ALTER PROCEDURE sp_login 
(
    @LoginNumber VARCHAR(255),
    @UserName VARCHAR(255),
    @Password VARCHAR(255)
)
AS

SELECT Active
FROM   Users
WHERE (LoginNumber = @LoginNumber)  
AND   (UserName    = @UserName) 
AND   (Password    = @Password)

 bool SuccessfulLogin()
    {
        string connectionString = ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString;
        // Your code should get the connection string from web.config

        using (SqlConnection conn = new SqlConnection(connectionString))
        {
            using (SqlCommand cmd = new SqlCommand("sp_login"))
            {
                cmd.CommandType = CommandType.StoredProcedure;

                cmd.Parameters.Add(new SqlParameter("@LoginNumber", txtLoginNumber.Text));
                cmd.Parameters.Add(new SqlParameter("@UserName", txtUserName.Text));
                cmd.Parameters.Add(new SqlParameter("@Password", txtPassword.Text));

                SqlParameter countParameter = new SqlParameter("@Active", SqlDbType.Bit,0);
                countParameter.Direction = ParameterDirection.Output;
                cmd.Parameters.Add(countParameter);

                conn.Open();
                cmd.Connection = conn;

                cmd.ExecuteNonQuery();
                
                conn.Close();

                return bool.Parse(cmd.Parameters["@Active"].Value.ToString());
               
            }
        }
    }
}