someone please check my SQL - SQL Server Forums

Please start any new threads on our new site at https://forums.sqlteam.com. We've got lots of great SQL Server experts to answer whatever question you can come up with.

All Forums

General SQL Server Forums

New to SQL Server Programming

someone please check my SQL

Author

Topic

Brian Badonde
Starting Member

2 Posts

Posted - 2010-06-18 : 04:37:18

hi,

can somebody please point out why i am receiving an 'ORA-00933: SQL command not properly ended' error message please?

SELECT
LU.LOADUNIT_ID,
P.PRODUCT_NR,
P.EAN,
P.NAME,
LC.BU_QUANTITY,
LU.STATUS_QUALITY

FROM
QWH_LU_CONTENTS_LOG AS LC,
LOAD_UNITS_FAST AS LU,
STORAGEPLACES AS SP,
storageareas AS sa,
QCM_WAREHOUSES AS W,
QCM_PROD_SERIALS AS SN,
QCM_MEASURE_UNITS AS MU,
QCM_SYSCLASSES AS sc_LU,
SP_CLASSES AS SPC,
QCM_LU_TYPES AS luts,
QCM_FIRMS AS f,
DELIVERIES AS d,
QCM_SYSCLASSES AS sc,
QCMV_MODE_PRODUCTS AS P INNER JOIN QCM_PROD_GROUPS ON P.PROD_GROUP_ID=QCM_PROD_GROUPS.PROD_GROUP_ID

WHERE
(((f.FIRM_NR)="UBIS")
AND
((LU.STATUS_QUALITY)="AV")
AND
((LC.LOADUNIT_ID)=[LU].[LOADUNIT_ID])
AND
((LU.SP_ID)=[SP].[SP_ID])
AND
((SP.SA_ID)=[sa].[sa_id])
AND
((sa.WH_ID)=[w].[wh_id])
AND
((P.PRODUCT_ID)=[LC].[PRODUCT_ID])
AND
((SN.PRODUCT_ID)=[LC].[PRODUCT_ID])
AND
((SN.PROD_SERIAL_ID)=[LC].[PROD_SERIAL_ID])
AND
((MU.M_UNIT_ID)=[P].[M_UNIT_ID])
AND
((LC.STATUS)<>'--')
AND
((LU.STATUS)=[sc_LU].[CLASS_VALUE])
AND
((sc_LU.CLASS_TYPE)='LOAD_UNITS_STATUS')
AND
((SP.SP_CLASS_ID)=[SPC].[sp_class_id])
AND
((luts.LU_TYPE_ID)=[lu].[lu_type_id])
AND
((LU.OWNER_ID)=[f].[firm_id])
AND
((LC.DELIVERY_ID)=[d].[delivery_id])
AND
((sc.CLASS_TYPE)='QUALITY_STATUS')
AND
((sc.CLASS_VALUE)=[lu].[status_quality]))

ORDER BY 4, 6, 2;

thank you,

madhivanan
Premature Yak Congratulator

22864 Posts

Posted - 2010-06-18 : 05:26:13

This site is for MS SQL Server. Post your questions at www.orafaq.com

Madhivanan

Failing to plan is Planning to fail

madhivanan
Premature Yak Congratulator

22864 Posts

Posted - 2010-06-18 : 05:27:01

Also try using single quotes instead of double quotes

Madhivanan

Failing to plan is Planning to fail

AndrewMurphy
Master Smack Fu Yak Hacker

2916 Posts

Posted - 2010-06-18 : 05:57:41

I think you will also run into promlems with a lack of enough "inner/left join" clauses.

select a1,b1,c1
from mytable1 a
inner join mytable2 b on b.key = a.key
left join mytable3 c on c.key = b.fkey

for each table queried, best practice would be to specify an explicit "join x on" clause.
otherwise you'll get an implicit cross-join with disastrous results and performance

Subscribe to SQLTeam.com

SQLTeam.com Articles via RSS

SQLTeam.com Weblog via RSS

- Advertisement -

Resources