strSQL = "EXECUTE dfGetForumSummaryPage @fid=" & oForumID & ", @days=" & fSortDays & ", @page=" & oPageID & _
	", @pageSize=" & fPageTopic & ", @sortkey='" & fSortKey & "', @sortorder='" & fSortOrder & "'"
Set rsForum = dbConn.Execute( strSQL )
If NOT rsForum.EOF Then  <-- Errors here

CREATE  PROCEDURE dfGetForumSummaryPage
	@fid INT,
	@days INT,
	@page INT,
	@pageSize INT,
	@sortkey VARCHAR(25),
	@sortorder VARCHAR(25)
AS
DECLARE @sql AS VARCHAR(200)
DECLARE @start INT
DECLARE @end INT
DECLARE @pageBoundary INT

-- Get our start and end position for our rows
SET @start = ((@page-1) * @pageSize) + 1
IF @@ERROR<> 0
	RETURN @@ERROR
SET @end = @start + @pageSize - 1

-- Create our temporary holding table for the recordset
BEGIN TRANSACTION GetDataSet
CREATE TABLE #PostTemp (
	RowID int IDENTITY(1,1) PRIMARY KEY,
	PostID int
)
IF @@ERROR<>0
	GOTO ErrorHandler

-- Insert the required PostIDs for this query
SELECT @sql = 'INSERT INTO #PostTemp (PostID) SELECT PostID FROM dbForumPosts '
SELECT @sql = @sql + 'WHERE (ForumID=' + CONVERT(VARCHAR(4),@fid) + ') AND (Parent=0) AND (deleted=0) AND '
SELECT @sql = @sql + '(LastPostDate > DATEADD(d,' + CONVERT(VARCHAR(4),-@days) + ',GETDATE()))'
SELECT @sql = @sql + ' ORDER BY ' + @sortkey + ' ' + @sortorder

EXEC( @sql )
IF @@ERROR<>0
	GOTO ErrorHandler

-- Get our upper bound for the page
SELECT @pageBoundary=MAX(RowID) FROM #PostTemp

-- Check our lower bounds for this page
IF @start > @pageBoundary
	GOTO ErrorHandler

-- Check our upper bounds for this page
IF @end > @pageBoundary
	SET @end = @pageBoundary

-- Now SELECT the records required
SELECT #PostTemp.PostID, dbo.dbForumPosts.Subject, dbo.dbForumPosts.AuthorID, 
	dbo.dbUserInfo.Handle, dbo.dbForumPosts.NumViews, 
	dbo.dbForumPosts.NumReplies, dbo.dbForumPosts.LastPostDate, 
	dbo.dbForumPosts.ForumID
FROM    #PostTemp 
INNER JOIN dbo.dbForumPosts ON #PostTemp.PostID = dbo.dbForumPosts.PostID 
INNER JOIN dbo.dbUserInfo ON dbo.dbForumPosts.AuthorID = dbo.dbUserInfo.UserID
WHERE ((#PostTemp.RowID >=@start) AND (#PostTemp.RowID <=@end))

DROP TABLE #PostTemp   <--Is this necessary?
COMMIT TRANSACTION GetDataSet
RETURN 0

ErrorHandler:
ROLLBACK TRANSACTION GetDataSet
RETURN @@ERROR
GO

quote:

---

>DROP TABLE #PostTemp <--Is this necessary?
No. Temp tables created in a sp are dropped automatically after
the sp executed. But...

---