SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
SET ANSI_PADDING ON
GO
CREATE TABLE [dbo].[requestmaster](
	[requestid] [nchar](8) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL,
	[unit] [nchar](10) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL,
	[requestno] [nchar](75) COLLATE SQL_Latin1_General_CP1_CI_AS NOT NULL,
	[requestdt] [datetime] NOT NULL,
	[recddt] [datetime] NOT NULL,
	[regndt] [datetime] NOT NULL,
	[remarks] [varchar](100) COLLATE SQL_Latin1_General_CP1_CI_AS NULL,
 CONSTRAINT [PK_requestmaster] PRIMARY KEY CLUSTERED 
(
	[requestid] ASC
)WITH (PAD_INDEX  = OFF, IGNORE_DUP_KEY = OFF) ON [PRIMARY]
) ON [PRIMARY]

GO
SET ANSI_PADDING OFF

IF OBJECT_ID ('dbo.InsertRequestMaster') IS NOT NULL
    DROP PROCEDURE dbo.InsertRequestMaster;
go
create procedure InsertRequestMaster
@cUnit nchar(10),
@cRequestno nchar(75),
@dRequestDt varchar (25),
@dRecdDt varchar (25),
@dRegnDate varchar (25),
@cRemarks varchar(100) = NULL
--@cRequestType nchar (4),
--@nAfQty int,
--@nAeQty int
AS
BEGIN
	DECLARE @cNextId nchar(8)
	DECLARE @RequestDt datetime
	DECLARE @RecdDt datetime
	DECLARE @RegnDt datetime

	Select @RequestDt = convert(varchar(25), @dRequestDt, 105)
	Select @RecdDt = convert(varchar(25), @dRecdDt, 105)
	Select @RegnDt = convert(varchar(25), @dRegnDate, 105)
	SELECT @cNextId= dbo.GetId(GetDate())
	
Print @cNextId
Print '------------'
Print @dRequestDt
--Print @RequestDt
Print '------------'
Print @dRecdDt
--Print @RecdDt
Print '------------'
Print @dRegnDate
--Print @RegnDt
Print '------------'
	SET XACT_ABORT ON;
	BEGIN TRANSACTION;
		
		--BEGIN TRY
			INSERT INTO RequestMaster (RequestId, Unit, RequestNo, RequestDt, RecdDt, RegnDt, Remarks) 
			VALUES (@cNextId, @cRequestno, @cUnit, @RequestDt, @RecdDt, @RegnDt, @cRemarks);
			
			UPDATE IdMaster set LastId = @cNextId
		--END TRY
		--BEGIN CATCH
		--	IF (XACT_STATE()) = -1
		--		Rollback transaction
		--	IF (XACT_STATE()) = 1
		--		Commit transaction
	    --END CATCH;
END 

Insert into RequestMaster 
	(requestid, unit, requestno, requestdt, recddt, regndt) values ('20000004','30 WG', '30 WG/LGS/1234/GIFTING', '12-12-2010','12-12-2010', '12-12-2010')

exec InsertRequestMaster
'30 WG', '30 WG/LGS/1234/GIFTING', '12-12-2010','12-12-2010' , '12-12-2010'

quote:

---

Originally posted by slimt_slimt

your update statement
"UPDATE IdMaster set LastId = @cNextId"
is missing the "FROM Mytable" part.

---