Need improvement in the Query - SQL Server Forums

Please start any new threads on our new site at https://forums.sqlteam.com. We've got lots of great SQL Server experts to answer whatever question you can come up with.

All Forums

SQL Server 2008 Forums

Transact-SQL (2008)

Need improvement in the Query

Author

Topic

kamii47
Constraint Violating Yak Guru

353 Posts

Posted - 2011-05-19 : 11:13:48

ALTER PROCEDURE [dbo].[uspIsLocaleKeyAndZipcodeExists]
@DropSiteKey varchar(5)
,@ZipCode varchar(11)
,@LoginUserID varchar(50)

AS
BEGIN
SET NOCOUNT ON;

declare @cnt as int

if(@LoginUserID is null)
begin
SELECT @cnt = COUNT(*)
FROM REF_ADDRESS_LIST_FILE
where RAL_DROPSITE_KEY like '%' + @DropSiteKey + '%'
AND RAL_DS_PHYSADD_ZIP4CODE like '%' + @ZipCode + '%'
End
else
begin
SELECT @cnt = COUNT(*)
FROM REF_ADDRESS_LIST_FILE
where RAL_DROPSITE_KEY like '%' + @DropSiteKey + '%'
AND RAL_DS_PHYSADD_ZIP4CODE like '%' + @ZipCode + '%'
And Left(RAL_DS_PHYSADD_ZIP4CODE, 3) in
(
SELECT distinct DISTRICTS.DIS_PK_ZIP_CODE
FROM DISTRICTS
WHERE DISTRICTS.DIS_PK_DISTRICT_ID in
(
SELECT UDR_FK_DISTRICT_ID = UDR_FK_DISTRICT_ID
FROM USER_DISTRICT
WHERE UDR_FK_LOGIN_ID = @LoginUserID
)
)
End

select @cnt
END

DonAtWork
Master Smack Fu Yak Hacker

2167 Posts

Posted - 2011-05-19 : 11:16:45

DDL, sample data and output?

An actual question perhaps?

http://weblogs.sqlteam.com/jeffs/archive/2008/05/13/question-needed-not-answer.aspx
How to ask: http://weblogs.sqlteam.com/brettk/archive/2005/05/25/5276.aspx
For ultra basic questions, follow these links.
http://www.sql-tutorial.net/
http://www.firstsql.com/tutor.htm
http://www.w3schools.com/sql/default.asp

Subscribe to SQLTeam.com

SQLTeam.com Articles via RSS

SQLTeam.com Weblog via RSS

- Advertisement -

Resources